acassis commented on code in PR #3657:
URL: https://github.com/apache/nuttx-apps/pull/3657#discussion_r3644837335


##########
system/readline/readline_common.c:
##########
@@ -72,6 +72,27 @@ struct cmdhist_s
 #ifdef CONFIG_READLINE_ECHO
 static const char g_erasetoeol[] = VT100_CLEAREOL;
 #endif
+#ifdef CONFIG_READLINE_EDIT
+static const char g_curleft[]  = {ASCII_ESC, '[', 'D'};
+static const char g_curright[] = {ASCII_ESC, '[', 'C'};
+#endif
+
+#ifdef CONFIG_READLINE_EDIT_EMACS

Review Comment:
   I tried replacing the code with memmove, but honestly it makes the code more 
obscure to read and also the original code already was using this kind of 
construction



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to