casaroli commented on code in PR #19510: URL: https://github.com/apache/nuttx/pull/19510#discussion_r3644981425
########## arch/arm/src/common/Toolchain.defs: ########## @@ -584,7 +584,28 @@ CELFFLAGS = $(CFLAGS) -fvisibility=hidden -mlong-calls # --target1-abs CXXELFFLAGS = $(CXXFLAGS)-fvisibility=hidden -mlong-calls ifeq ($(CONFIG_PIC),y) - CFLAGS += --fixed-r10 + # This has to go in ARCHCFLAGS rather than CFLAGS. Nearly every board + # Make.defs includes this file and then assigns Review Comment: Updated the comment to try to prevent anyone from reverting this back to `CFLAGS`. I can remove entirely if you like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
