casaroli commented on PR #19537: URL: https://github.com/apache/nuttx/pull/19537#issuecomment-5082655283
The failing `sim:alsa` CI job is unrelated to this PR's ELF-loader change. This PR changes only `binfmt/elf.c`; the simulator failure is a pre-existing CMake integration problem in the bundled LAME/libmad codec path. The failure first appears while compiling `arch/sim/src/sim/sim_offload.c` because the CMake `arch` target does not expose the bundled codec headers. After correcting that, the CMake LAME target also needs its x86 runtime-dispatch vector sources to link successfully. The fixes are tracked separately: - NuttX codec-header integration: https://github.com/apache/nuttx/pull/19541 - Companion Apps LAME CMake source fix: https://github.com/apache/nuttx-apps/pull/3666 Both fixes were validated together with the CI-equivalent `sim:alsa` CMake/Ninja build. The Apps PR should merge first; this PR's CI will then use the updated Apps `master`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
