acassis commented on code in PR #19503:
URL: https://github.com/apache/nuttx/pull/19503#discussion_r3652219127


##########
drivers/syslog/syslog_channel.c:
##########
@@ -139,9 +139,9 @@ static syslog_channel_t g_rtt_channel =
 #  ifdef CONFIG_SYSLOG_IOCTL
   , "rtt"
 #  endif
-#  ifdef CONFIG_SYSLOG_CRLF
-  , SYSLOG_CHANNEL_DISABLE_CRLF
-#  endif
+  /* sc_state defaults to 0: CRLF conversion ON when CONFIG_SYSLOG_CRLF=y.
+   * Needed for MobaXterm / Windows RTT (LF-only causes staircase wrap).

Review Comment:
   @jacksonGreenStone did you use AI? RTT (Real Time Trace) has nothing to do 
with Windows RTT (an accessibility feature of Windows). Please use only 
"Windows" here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to