xiaoxiang781216 commented on code in PR #19536: URL: https://github.com/apache/nuttx/pull/19536#discussion_r3654045384
########## include/nuttx/fs/xipfs.h: ########## @@ -0,0 +1,168 @@ +/**************************************************************************** + * include/nuttx/fs/xipfs.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __INCLUDE_NUTTX_FS_XIPFS_H +#define __INCLUDE_NUTTX_FS_XIPFS_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <sys/types.h> +#include <stdint.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* Maximum length of one path component, not including the NUL terminator. + * Depth comes from the directory an entry belongs to rather than from its + * name, so this bounds a component and not a whole path -- which is what + * statfs reports it as, in f_namelen. + */ + +#define XIPFS_NAME_MAX 31 + +/* Longest path reported back to an application, separators included. A path + * is bounded only by the depth of the tree, so this is a reporting limit and + * not a filesystem one: a path longer than this is truncated from the front, + * which keeps the part that identifies the file. + */ + +#define XIPFS_PATH_MAX 127 Review Comment: so, it's better to keep XIPFS_NAME_MAX, but reuse PATH_MAX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
