xiaoxiang781216 commented on code in PR #19528: URL: https://github.com/apache/nuttx/pull/19528#discussion_r3654668010
########## arch/risc-v/src/common/riscv_backtrace.c: ########## @@ -55,6 +129,61 @@ static inline uintptr_t getfp(void) return fp; } +/**************************************************************************** + * Name: backtrace_add_range + * + * Description: + * Append one candidate stack range to a segment. + * + ****************************************************************************/ + +static void backtrace_add_range(struct backtrace_segment_s *segment, + uintptr_t *base, uintptr_t *limit +#ifdef CONFIG_ARCH_ADDRENV + , FAR struct addrenv_s *addrenv Review Comment: remove FAR from the code base ########## arch/risc-v/src/common/riscv_backtrace.c: ########## @@ -64,29 +193,24 @@ static inline uintptr_t getfp(void) ****************************************************************************/ nosanitize_address +noinline_function Review Comment: merge nosanitize_address and noinline_function into one line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
