ppisa commented on code in PR #3624: URL: https://github.com/apache/nuttx-apps/pull/3624#discussion_r3655077002
########## graphics/microwindows/Make.defs: ########## @@ -0,0 +1,50 @@ +############################################################################ +# apps/graphics/microwindows/Make.defs +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# +############################################################################ + +ifneq ($(CONFIG_GRAPHICS_MICROWINDOWS),) +CONFIGURED_APPS += $(APPDIR)/graphics/microwindows + +# It allows `microwindows/src/include` import. + +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include +CXXFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/include +CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/graphics/microwindows/microwindows/src/drivers Review Comment: These are required even for other applications using Microwindows which is main goal for integration. There is global problem with NuttX with components includes because they are not propagated, header files copied` into `make export` archive. So there should be in `Make.defs` but ideally added to something like `APP_COMPONENT_INCLUDE_DIRS +=` which is then converted by substitution into `CFLAGS` and `CXXFLAGS` for in tree applications builds and iterated during `make export` which copies such directories into target archive `include` directory. We have this problem with our SHV, uLUt and it would be problem with more other components which can be build as part of standard NuttX build and used through more sub-directories in APPS tree but are broken after export. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
