ppisa commented on PR #3624: URL: https://github.com/apache/nuttx-apps/pull/3624#issuecomment-5097909308
> > Generally, I see as the best solution do not need for these to be defined by build system to zero. > > On the Microwindows side, for various reasons the idiom of `#if RTEMS` etc is used a lot more than `#ifdef RTEMS`, mostly so that the same mechanism can be used to turn options on or off without changing an #ifdef to an #if. However, it was not the intent to force developers to find all cases of #if SYM and pass -DSYM=0 everywhere. Thus, I do not agree the best solution is to set otherwise undefined symbols to 0. OK, I have tried to add checks for defines presence in Microwindows code. I agree that there is some added complexity. I have repeated some defines sequences because with checks for define presence the conditions testing multiple target OS alternatives are hard to write such that warning is prevented https://github.com/ghaerr/microwindows/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
