casaroli commented on code in PR #19568:
URL: https://github.com/apache/nuttx/pull/19568#discussion_r3665697700
##########
drivers/syslog/syslog_write.c:
##########
@@ -215,7 +215,7 @@ ssize_t syslog_write_foreach(FAR const char *buffer,
* number of bytes written to any existing channel.
*/
- if (nwritten > nwritten_max)
+ if ((ssize_t)nwritten > nwritten_max)
Review Comment:
Done — `nwritten` is now `ssize_t` and the cast is gone.
Re-ran the same A/B on `mps2-an521` (armv8-m): identical to before, 5681
lines of one repeated fragment in 25s without the fix, 175 lines of normal
ostest output with it, and `ostest_main: putenv(Variable1=BadValue3)`
completing instead of being cut at `putenv(Varia`.
`nwritten` is never negative, so the remaining `nwritten < buflen`
comparisons are unaffected. Commit message updated to describe the type change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
