ricardgb commented on code in PR #3630:
URL: https://github.com/apache/nuttx-apps/pull/3630#discussion_r3673167475
##########
netutils/mdns/Kconfig:
##########
@@ -51,11 +51,15 @@ config NETUTILS_MDNS_PRIORITY
config NETUTILS_MDNS_STACKSIZE
int "mDNS stack size"
- default DEFAULT_TASK_STACKSIZE
+ default 8192
---help---
- The default (4KiB) is adequate for simple networks but this will
- most likely need to be increased if there are many network
devices
- attached that could send queries.
+ Stack size for the mDNS responder task. The bundled mjansson
+ responder uses a fairly deep stack (record parsing with name
+ decompression plus the send/receive buffers), so the previous
Review Comment:
Good point — trimmed the help text to just describe the option (stack size +
when to bump it) and dropped the problem/rationale narrative:
```
Stack size for the mDNS responder task. 8KiB is adequate for
typical networks; increase it if many network devices send queries.
```
Pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
