JorgeGzm commented on code in PR #19579: URL: https://github.com/apache/nuttx/pull/19579#discussion_r3683340932
########## drivers/usbhost/usbhost_hidkbd.c: ########## @@ -238,8 +256,12 @@ struct usbhost_state_s struct work_s rwork; /* For interrupt transfer work */ int16_t nbytes; /* # of bytes actually transferred */ #endif -#ifndef CONFIG_HIDKBD_NODEBOUNCE - uint8_t lastkey[6]; /* For debouncing */ +#if !defined(CONFIG_HIDKBD_NODEBOUNCE) || defined(CONFIG_HIDKBD_KBDUPPER) + uint8_t lastkey[6]; /* Keys down in the previous report */ +#endif +#ifdef CONFIG_HIDKBD_KBDUPPER + struct keyboard_lowerhalf_s lower; /* Keyboard upper-half interface */ Review Comment: Agreed, better to coordinate. My idea was to create a system/kbd in a separate PR, merging what examples/hidkbd and examples/keyboard do today, so **examples/lvglterm** and **NXDoom** use the same thing instead of each one handling the keyboard its own way. Until that is agreed, I will put this PR on hold, so I do not add a third variant while the encoding work is in progress. @linguini1 @ppisa, does that fit what you have in mind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
