JorgeGzm commented on code in PR #19586:
URL: https://github.com/apache/nuttx/pull/19586#discussion_r3687716909


##########
drivers/usbhost/Kconfig:
##########
@@ -344,9 +344,16 @@ config USBHOST_HIDKBD
        bool "HID Keyboard Class Support"
        default n
        depends on !INT_DISABLE
+       select INPUT

Review Comment:
   `select INPUT_KEYBOARD` alone is not enough: `drivers/input/Make.defs:25` 
gates the whole directory on ifeq `($(CONFIG_INPUT),y)`, so the sources are 
never compiled and the link fails.
   
   **usbhost_hidkbd.c: undefined reference to keyboard_event**
   **usbhost_hidkbd.c: undefined reference to keyboard_register**
   **usbhost_hidkbd.c: undefined reference to keyboard_unregister**
   
   This is also why `USBHOST_HIDMOUSE`, fifteen lines below in the same file, 
selects both `INPUT` and `INPUT_MOUSE`. I kept the pair for symmetry with it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to