casaroli commented on code in PR #3673: URL: https://github.com/apache/nuttx-apps/pull/3673#discussion_r3690469056
########## testing/ostest/Makefile: ########## @@ -144,10 +144,21 @@ CSRCS += sigev_thread.c endif endif -ifeq ($(CONFIG_ARCH_HAVE_FORK),y) -ifeq ($(CONFIG_SCHED_WAITPID),y) +# Each test is built where the primitive it tests exists. See ostest.h for the +# one transitional exception. + +ifeq ($(CONFIG_TASK_FORK),y) +CSRCS += task_fork.c +else ifeq ($(CONFIG_ARCH_HAVE_FORK)$(CONFIG_ARCH_HAVE_TASK_FORK),y) Review Comment: replaced this with nested `ifeq`. This is required for this to merge before the nuttx PR. We can fix this with a follow up pr when the companion pr in nuttx gets merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
