JorgeGzm opened a new pull request, #19591:
URL: https://github.com/apache/nuttx/pull/19591
## Summary
Fixes a normalisation failure that apache/nuttx#19586 left on master.
That change removed `HIDKBD_ENCODED` and made `USBHOST_HIDKBD` select
`INPUT`, so four configurations now name an option that no longer exists or
one that the select provides, and they do not survive a refresh:
```
$ ./tools/refresh.sh --silent linum-stm32h753bi:lvglterm_kbda
[1/1] Normalize linum-stm32h753bi:lvglterm_kbda
43d42
< CONFIG_HIDKBD_ENCODED=y
45d43
< CONFIG_INPUT=y
$ git status
M boards/arm/stm32h7/linum-stm32h753bi/configs/lvglterm_kbda/defconfig
```
The four are:
```
boards/arm/sama5/sama5d4-ek/configs/ipv6 CONFIG_INPUT
boards/arm/sama5/sama5d4-ek/configs/nsh CONFIG_INPUT
boards/arm/sama5/sama5d4-ek/configs/nxwm CONFIG_INPUT
boards/arm/stm32h7/linum-stm32h753bi/configs/lvglterm_kbda
CONFIG_HIDKBD_ENCODED, CONFIG_INPUT
```
They are covered by `arm-07` and `arm-08`, so the normalisation step fails
in both jobs today.
Removing the lines is the whole fix. `INPUT` still ends up enabled, through
the select, and encoding now comes from `INPUT_KEYBOARD_BYTESTREAM`, which
the one configuration that wanted it already sets.
## Impact
None on behaviour. The resulting `.config` is identical, which is why the
build never noticed: Kconfig drops an option that no longer exists without
saying anything, and only the refresh compares the file before and after.
Worth recording for anybody making a similar change: adding a `select` makes
every explicit `CONFIG_X=y` in a defconfig redundant, and `savedefconfig`
then strips it. The three sama5d4-ek configurations were never touched by
the change that broke them, so finding them meant refreshing every
configuration that enables `USBHOST_HIDKBD`, not just the ones being edited.
## Testing
Every configuration in the tree that enables `USBHOST_HIDKBD`,
`INPUT_KEYBOARD` or `EXAMPLES_LVGLTERM` was refreshed, against the current
nuttx-apps master. None of them changes any more:
```
$ ./tools/refresh.sh --silent <each one>
$ git status
nothing to commit, working tree clean
```
The four configurations still build, along with the rest of the keyboard
configurations, inside the CI container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
