casaroli commented on code in PR #3673: URL: https://github.com/apache/nuttx-apps/pull/3673#discussion_r3699519553
########## system/libuv/Makefile: ########## @@ -144,7 +144,15 @@ CSRCS += runner.c CSRCS += runner-unix.c CSRCS += echo-server.c -CSRCS += $(wildcard libuv/test/test-*.c) +# test-fork.c and test-pipe-close-stdout-read-stdin.c call fork(). Every +# test they define is already excluded from the task list on NuttX by +# 0001-libuv-port-for-nuttx.patch, so they are dead code here. Review Comment: I think we should try to enable this after we have real `fork()` working. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
