casaroli commented on PR #19600: URL: https://github.com/apache/nuttx/pull/19600#issuecomment-5170620453
> I have no issue with the BSD code being converted to pure Apache 2.0 following the ASF headers. Some files were jointly copyrighted with Cadenux LLC which I owned many years ago and I was the only person doing the development. So I am comfortable with all of that. The only concern would be the code that has a some ancient uCLinux influenced logic in it. This is original code but derives from ancient GPL uClinux code in some logical sense (although I am avoiding the word "derived" because of its copyright implications). I think that is only one file (?) If everyone else is comfortable, then I am too. I would wait until people in Europe, especially Alin, have a chance to weigh in, however. Alin did all of the original BSD/GPL to Apache licensing analysis and changes when we first joined the ASF so his opinion carries the greatest weight. Thanks Greg, and the file you are thinking of is not in this PR. That is ldnxflat.c: its header says "converted from elf2flt.c" and carries Greg Ungerer's and Phil Blundell's copyrights. It stays out of tree in buildroot, and NuttX keeps calling it as an external tool exactly as today. What is imported is six files: mknxflat.c, nxflat_thunk.h, thunk_arm.c, thunk_thumb2.c and the two dyncall skeletons. mknxflat.c says "Modified from ldelflib", the code you describe as yours and Cadenux's, and I grepped all six for elf2flt, uClinux, XFLAT and GPL — there is nothing. I have converted those six to the ASF header in a separate commit, so the change is reviewable on its own and easy to drop or reword. Waiting on Alin before this goes anywhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
