casaroli commented on code in PR #3693: URL: https://github.com/apache/nuttx-apps/pull/3693#discussion_r3710481763
########## examples/fdpicxip/modules/cxxuser.cpp: ########## @@ -87,7 +90,7 @@ static Instance g_self; #define USER_FAIL_OWN_CTOR 0x01 #define USER_FAIL_LIB_CTOR 0x02 #define USER_FAIL_ORDER 0x04 -#define USER_FAIL_PRIVATE 0x08 +#define USER_FAIL_SHARED 0x08 Review Comment: Keeping `0x08` as `PRIVATE` and adding `SHARED` at `0x10` would imply the two can be reported independently, which would not be true. Also, `USER_FAIL_SHARED` is only used here and `xipfs_main.c`, so I just renamed the flag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
