xiaoxiang781216 commented on PR #19735: URL: https://github.com/apache/nuttx/pull/19735#issuecomment-5229996558
> Hi @xiaoxiang781216 - I can shift the changes to the BSD version, but I can't confirm the cited improvements on other architectures. I'd like people with real hardware to benchmark the different architectures and verify they see similar gains and no regressions. > we can verify your change on the different hardware. > You can benchmark with the test in [apache/nuttx-apps#3706](https://github.com/apache/nuttx-apps/pull/3706) - it checks correctness as well as speed, so a run shows both the gain and the absence of any regression. > > Let me know if you still want me to shift the changes and there are others that can test on real hardware before we merge. > yes, it is better to keep the general optimzaition out of the arch specific code. > (I did run some benchmarks on qemu, but had wide spread in results, so I don't have confidence in an emulated synthetic result!) do you switch qemu to icount mode? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
