Abhishekmishra2808 commented on code in PR #19767: URL: https://github.com/apache/nuttx/pull/19767#discussion_r3759230842
########## include/sys/prctl.h: ########## @@ -79,6 +79,20 @@ #define PR_SET_DUMPABLE 5 #define PR_GET_DUMPABLE 6 +/* PR_NSHCRED_ENABLE — set GROUP_FLAG_NSHCRED on this task group. + * Requires euid == 0. Not inherited by child task groups. + * Required for PR_NSHCRED_AUTHSETEID. + * + * PR_NSHCRED_AUTHSETEID — verify username/password against the passwd Review Comment: After hard-drop, raise needs a privileged API. If that API only checks an agent flag (old TOKEN), userspace can skip verify and still raise. `AUTHSETEID `binds verify and raise together for that reason (on flat builds with no memory isolation). Soft-drop / saved UIDs avoids kernel passwd checks, but then raise-after-hard-drop goes away. ########## include/sys/prctl.h: ########## @@ -79,6 +79,20 @@ #define PR_SET_DUMPABLE 5 #define PR_GET_DUMPABLE 6 +/* PR_NSHCRED_ENABLE — set GROUP_FLAG_NSHCRED on this task group. + * Requires euid == 0. Not inherited by child task groups. + * Required for PR_NSHCRED_AUTHSETEID. + * + * PR_NSHCRED_AUTHSETEID — verify username/password against the passwd Review Comment: Do you prefer keeping atomic kernel verify for hard-drop, or dropping hard-drop and using soft-drop only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
