Abhishekmishra2808 opened a new pull request, #3727: URL: https://github.com/apache/nuttx-apps/pull/3727
## Summary - Emergency CI / NTFC is failing after https://github.com/apache/nuttx-apps/pull/3714 with `TimeoutError: device boot timeout` on `sim/citest` and `qemu-rv/citest`. - `nsh_consolemain()` always starts the session with `NSH_LOGIN_LOCAL`, even when `CONFIG_NSH_CONSOLE_LOGIN` is disabled. PR 3714 treated any non-`NONE` session as a login and rewrote `nsh>` to `nsh#` whenever `CONFIG_SCHED_USER_IDENTITY` was enabled. - NTFC detects boot by looking for `CONFIG_NSH_PROMPT_STRING` (`nsh>`), so those citest configs (USER_IDENTITY on, console login off) never come up. - Apply `#`/`$` markers only after a successful console or telnet login (or `su`). No-login boot keeps `nsh>`. ## Impact - `CONFIG_SCHED_USER_IDENTITY` boards without NSH login keep the configured prompt at boot (CI/NTFC compatible). - Login-enabled sessions and `su` still get `nsh#` / `nsh$`. - No change when `CONFIG_SCHED_USER_IDENTITY` is disabled. ## Testing Logic review against `nsh_consolemain()` (`NSH_LOGIN_LOCAL`) and `sim/citest` / `qemu-rv/citest` (`CONFIG_SCHED_USER_IDENTITY=y`, no `CONFIG_NSH_CONSOLE_LOGIN`). Expected: - No-login boot: `nsh> ` (NTFC boot detection) - After console/telnet login or `su`: `nsh# ` / `nsh$ ` Please re-run emergency CI / NTFC `sim/citest` to confirm boot detection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
