Fishwaldo commented on PR #19745: URL: https://github.com/apache/nuttx/pull/19745#issuecomment-5300987344
Hi @raiden00pl I'll split that large commit up into GCC and Qemu fixes. I originally squashed some commits together with a broad goal of: 1. Get QEMU working again 2. Split out PCI specific code so we could have a generic XHCI implementation at bolt PCI & directly mapped implementations (like the EIC7700) on top 3. Get USB Hub working (as the StarPro64 uses a onboard hub between the SOC and ports Agree it's a large change, but with no only one other in tree board (the qemu-intel jumbo) I hoped you guys could accept it via one PR rather than multiple. (Honest fact. I really don't have a lot of spare time to iterate on these PR's. We have had this running in somewhat of a production setting at work on an older 12 Frankenstein branch and I'm just trying to send these changes back as best I can during my spare time. I did use Claude to tidy up and forward port some of these changes but it's a mix of Human and AI fixes. - the scratchpad at 0 was human debugged as we didn't see it on our EIC7700 board at all. I don't know if that's a qemu quirk or legit, but it's what I observed trying to get things up and running) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
