acassis commented on code in PR #19854:
URL: https://github.com/apache/nuttx/pull/19854#discussion_r3789317159
##########
fs/vfs/fs_read.c:
##########
@@ -176,6 +176,16 @@ ssize_t file_readv(FAR struct file *filep,
return -EFAULT;
}
+#if defined(CONFIG_BUILD_KERNEL) && CONFIG_ARCH_TEXT_VBASE == 0
+
+ /* -------------------- DO NOT REMOVE --------------------
+ * Only for kernel builds with CONFIG_ARCH_TEXT_VBASE == 0.
+ * In this case we have to allow the NULL buffer otherwise
+ * kernel builds will fail to load elf binaries found at 0.
+ */
+
+#else
+
Review Comment:
@ldube keep this comment and change to just an #if with negated test as you
had done previously
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
