Ouss4 commented on a change in pull request #380:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487385182
##########
File path: Make.defs
##########
@@ -108,10 +108,6 @@ define REGISTER
$(Q) touch "$(BUILTIN_REGISTRY)$(DELIM).updated"
endef
-define ARLOCK
- $(Q) flock $1.lock $(call ARCHIVE, $1, $(2))
Review comment:
Hmmmm flock was necessary to get the nightly build in a stable
situation. @xiaoxiang781216 could you please comment here.
##########
File path: Application.mk
##########
@@ -131,13 +131,12 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT)
$(if $(and $(CONFIG_BUILD_LOADABLE),$(CXXELFFLAGS)), \
$(call ELFCOMPILEXX, $<, $@), $(call COMPILEXX, $<, $@))
-.built: $(OBJS)
+link:
ifeq ($(CONFIG_CYGWIN_WINTOOL),y)
- $(call ARLOCK, "${shell cygpath -w $(BIN)}", $^)
+ $(call ARCHIVE_ADD, "${shell cygpath -w $(BIN)}", $(OBJS))
else
- $(call ARLOCK, $(BIN), $^)
+ $(call ARCHIVE_ADD, $(BIN), $(OBJS))
endif
- $(Q) touch $@
Review comment:
Directories that are going to be cleaned are filtered-out using this
marker ".built". Removing it will keep object files (and other autogenerated
files) after a clean/distclean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
