mpflanzer commented on PR #19891: URL: https://github.com/apache/nuttx/pull/19891#issuecomment-5370404070
> @mpflanzer please fix ci error: https://github.com/apache/nuttx/actions/runs/32227114781/job/96215519806?pr=19891 That seems a bit of an issue. I think the underlying problem is that Nuttx still adds its own `include/cxx` directory to the compiler's search path even if `CONFIG_LIBCXXTOOLCHAIN` is selected. That option only seem to control whether `--nostdinc++` is passed to the compiler or not. Having both sets of C++ headers is then causing problems to find the right functions. To avoid this situation without having to touch any of the include behavior I cannot include `math.h` and `stdlib.h` in the `bits/std_abs.h` helper and the `bits` directory needs to be renamed to something else as it conflicts with the directory provided by the gcc toolchain. I now forward declare the `abs` variants in the `std_abs.h` helper file (instead of including the other headers) and renamed the directory (from `bits` to `nuttx`). Let me know if that is fine or if you would like to do it differently. I run the failing OOT test locally and it is now passing. My custom test is still behaving correctly with the new changes (same output as before). I also tested this one now with both settings of `CONFIG_LIBCXXTOOLCHAIN`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
