xiaoxiang781216 commented on code in PR #3755:
URL: https://github.com/apache/nuttx-apps/pull/3755#discussion_r3877251664


##########
system/nxinit/parser.h:
##########
@@ -56,4 +57,17 @@ int init_parse_arguments(FAR char *buf, bool dup, int argc, 
FAR char **argv);
 int init_parse_configs(FAR const struct parser_s *parser);
 int init_parse_config_file(FAR const struct parser_s *parser,
                            FAR const char *file);
+
+#ifdef CONFIG_SYSTEM_NXINIT_TEST

Review Comment:
   let's expose init_parse_config_buffer directly



##########
system/nxinit/Kconfig:
##########
@@ -70,6 +70,7 @@ config SYSTEM_NXINIT_ACTION_WARN_SLOW
 
 config SYSTEM_NXINIT_ACTION_EVENTS_MAX
        int "Max number of events"
+       default 2 if SYSTEM_NXINIT_TEST

Review Comment:
   let's change the default value directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to