casaroli commented on code in PR #19940: URL: https://github.com/apache/nuttx/pull/19940#discussion_r3879812337
########## tools/fdpic/init-array.ld: ########## @@ -0,0 +1,49 @@ +/**************************************************************************** + * tools/fdpic/init-array.ld + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/* Bounds for crt0.c to walk. + * + * The linker's built-in script defines __init_array_start and + * __init_array_end when it links an executable and not when it links a + * shared object, because a shared object is expected to be constructed by + * whoever loaded it, from DT_INIT_ARRAY. A NuttX module is loaded that way + * only through dlopen(); one that exec() runs enters its own crt0 and has to + * find the array itself. Reading DT_INIT_ARRAY out of _DYNAMIC is not an + * answer, because the addresses there are link-time ones and an FDPIC object + * cannot translate them: its two segments move independently and only the + * loader knows by how much. + * + * INSERT keeps the built-in script and adds to it, so this file replaces + * nothing. + */ + +SECTIONS +{ + .init_array : Review Comment: Agree. Once the build is in tree this belongs in `libs/libc/elf/gnu-elf.ld` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
