xiaoxiang781216 commented on code in PR #20004:
URL: https://github.com/apache/nuttx/pull/20004#discussion_r3888363420
##########
boards/xtensa/esp32s3/esp32s3-xiao/src/esp32s3_bringup.c:
##########
@@ -51,6 +51,10 @@
# include "esp32s3_board_sdmmc.h"
#endif
+#ifdef CONFIG_ESP32S3_I2C
Review Comment:
update the commit message "Merge branch 'master' into
feature/xiao-sdcard-spi"
##########
boards/xtensa/esp32s3/esp32s3-xiao/src/esp32s3_bringup.c:
##########
@@ -132,8 +132,9 @@ int esp32s3_bringup(void)
if (ret < 0)
{
syslog(LOG_ERR, "ERROR: Failed to initialize SDMMC: %d\n", ret);
+ }
Review Comment:
squash into the previous patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
