xiaoxiang781216 commented on code in PR #20008:
URL: https://github.com/apache/nuttx/pull/20008#discussion_r3888375939
##########
net/netdev/Kconfig:
##########
@@ -42,6 +42,16 @@ config NETDEV_CAN_STATE_IOCTL
Enable support for ioctl() commands to set/see CAN or LIN
controller-state
(NOTE: Not supported by all drivers)
+config NETDEV_CAN_ERROR_IOCTL
Review Comment:
should we merge all NETDEV_CAN_xxx_IOCTL into NETDEV_CAN_IOCTL?
##########
net/netdev/netdev_ioctl.c:
##########
@@ -1308,6 +1309,23 @@ static int netdev_ifr_ioctl(FAR struct socket *psock,
int cmd,
break;
#endif
+#if defined(CONFIG_NETDEV_IOCTL) && defined(CONFIG_NETDEV_CAN_ERROR_IOCTL)
+ case SIOCGCANERRORS: /* Get CAN error counters and state */
Review Comment:
let's merge all SIOCxCANxxx into one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
