xiaoxiang781216 commented on code in PR #3759:
URL: https://github.com/apache/nuttx-apps/pull/3759#discussion_r3888396235
##########
testing/ostest/wqueue.c:
##########
@@ -44,54 +50,467 @@
#define SLEEP_TIME (100 * 1000)
#define TEST_COUNT (100)
#define VERIFY_COUNT (100)
+#define WQUEUE_TEST_TIMEOUT_SEC 2
-#ifdef CONFIG_SCHED_LPWORK
-# define TEST_QUEUE LPWORK
-# define TEST_QUEUE_PRIORITY CONFIG_SCHED_LPWORKPRIORITY
-#else
-# define TEST_QUEUE HPWORK
-# define TEST_QUEUE_PRIORITY CONFIG_SCHED_HPWORKPRIORITY
-#endif
+#define MULTI_QUEUE_COUNT 4
+#define MULTI_QUEUE_LOOPS 4
+#define MULTI_WORK_PER_QUEUE 8
+#define CUSTOM_PRIORITY 100
+#define CUSTOM_STACKSIZE 2048
+
+/****************************************************************************
+ * Private Types
+ ****************************************************************************/
+
+typedef FAR void *(*test_thread_entry_t)(FAR void *arg);
/****************************************************************************
* Private Functions
****************************************************************************/
+static int wait_sem(FAR sem_t *sem)
+{
+#ifdef __KERNEL__
Review Comment:
why need check `__KERNEL__`
##########
testing/ostest/wqueue.c:
##########
@@ -43,6 +45,405 @@
#include "ostest.h"
+#ifdef CONFIG_DISABLE_PTHREAD
Review Comment:
remove the check
##########
testing/ostest/Kconfig:
##########
@@ -54,11 +54,12 @@ endif
config TESTING_OSTEST_WQUEUE
bool "Work queue tests"
default y
- depends on !DISABLE_PTHREAD
- depends on (BUILD_FLAT && SCHED_WORKQUEUE) || LIBC_USRWORK
+ depends on (BUILD_FLAT && !DISABLE_PTHREAD && SCHED_WORKQUEUE) ||
LIBC_USRWORK
Review Comment:
sqaush into the first patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
