13022591351 commented on PR #19982: URL: https://github.com/apache/nuttx/pull/19982#issuecomment-5473472564
Thanks. I added a comment before the loop explaining that the same work structure may be executing concurrently on multiple workers, so synchronous cancellation waits for one worker at a time and rescans until no callback remains. The calling worker is excluded to avoid self-deadlock. hartmannathan ***@***.***> 于2026年8月31日周一 09:28写道： > ***@***.**** commented on this pull request. > ------------------------------ > > In libs/libc/wqueue/work_cancel.c > <https://github.com/apache/nuttx/pull/19982#discussion_r3891145835>: > > > > - /* Get exclusive access to the work queue */ > + for (; ; ) > > Suggestion: Maybe add a comment to explain this, so people who read the > code later will have an easier time understanding it? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/nuttx/pull/19982?email_source=notifications&email_token=AIAPCTIQYY4AWYUP4BXGTB35MTIE5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBWGI2DSMZYGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r3891145835>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIAPCTIKDNKD6BZDNTNJBJ35MTIE5AVCNFSNUABFKJSXA33TNF2G64TZHMZDEOBRGAZTENZTHNEXG43VMU5TKMRWGU3DMMJWGI32C5QC> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AIAPCTORDK4OTC3WLAGZOW35MTIE5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBWGI2DSMZYGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AIAPCTKE4ZC53RNRJTXWZV35MTIE5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTKMBWGI2DSMZYGE32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
