daniel-p-carvalho commented on PR #3789: URL: https://github.com/apache/nuttx-apps/pull/3789#issuecomment-5722536885
Hi @wenquan2015, thanks for tagging! The changes look great — moving the IGMP join after `SIOCGIFADDR` and removing the `CONFIG_BUILD_FLAT` restriction via the atomic status file are solid improvements. Just a heads up regarding PR #3782: it adds P2P delay support, which introduces the P2P multicast join (`224.0.0.107`) and a `last_transmitted_pdelayreq` field in `struct ptpd_status_s`. Whichever PR is merged first, the rebase will be trivial to align both (placing the P2P join in your new post-`SIOCGIFADDR` block and dumping the new status field in `ptp_dump_status_file()`). LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
