royzah commented on code in PR #20191:
URL: https://github.com/apache/nuttx/pull/20191#discussion_r4052153564


##########
arch/arm64/src/imx9/Kconfig:
##########
@@ -81,6 +81,7 @@ config IMX9_BOOTLOADER
        bool "Bootloader"
        select ARM64_DECODEFIQ if ARCH_ARM64_EXCEPTION_LEVEL = 3
        select IMX9_DDR_TRAINING if ARCH_ARM64_EXCEPTION_LEVEL = 3
+       select IMX9_ELE

Review Comment:
   `imx9_trdc.c` calls `imx9_ele_init()` and builds under `IMX9_BOOTLOADER`, so 
it won't link without this:
   
https://github.com/apache/nuttx/blob/master/arch/arm64/src/imx9/imx9_trdc.c#L760
   
   Same pattern as `IMX9_AHAB_BOOT` a few lines down:
   https://github.com/apache/nuttx/blob/master/arch/arm64/src/imx9/Kconfig#L116



##########
arch/arm64/src/imx9/Make.defs:
##########
@@ -103,9 +103,16 @@ endif
 ifeq ($(CONFIG_IMX9_BOOTLOADER),y)
   CHIP_CSRCS += imx9_system_ctl.c
   CHIP_CSRCS += imx9_trdc.c
+endif
+
+ifeq ($(CONFIG_IMX9_ELE),y)
   CHIP_CSRCS += imx9_ele.c
 endif
 
+ifeq ($(CONFIG_IMX9_RNG),y)
+  CHIP_CSRCS += imx9_rng.c
+endif
+
 ifeq ($(CONFIG_IMX9_ROMAPI),y)
   CHIP_CSRCS += imx9_romapi.c
 endif

Review Comment:
   My mistake, `git add -A` swept up build artifacts. Removed, back to 4 files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to