acassis commented on code in PR #20223:
URL: https://github.com/apache/nuttx/pull/20223#discussion_r4062703722
##########
arch/xtensa/src/esp32s3/esp32s3_idle.c:
##########
@@ -104,7 +104,12 @@ static void up_idlepm(void)
/* Release the stay above: it only forces this one state change. */
pm_relax(PM_IDLE_DOMAIN, PM_NORMAL);
- newstate = PM_NORMAL;
+
+ /* Without this, oldstate goes stale after the first wakeup and the
+ * state machine wedges in PM_NORMAL forever -- see commit message.
+ */
+
+ oldstate = PM_NORMAL;
Review Comment:
@FelipeMdeO esp32_idle.c has this exactly same code, please analyze
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
