Ouss4 commented on a change in pull request #1754:
URL: https://github.com/apache/incubator-nuttx/pull/1754#discussion_r487522557
##########
File path: arch/xtensa/src/esp32/esp32_spiflash.c
##########
@@ -131,7 +155,7 @@ static struct esp32_spiflash_s s_esp32_spiflash1 =
.bwrite = esp32_bwrite,
.read = esp32_read,
.ioctl = esp32_ioctl,
-#if defined(CONFIG_MTD_BYTE_WRITE)
+#ifdef CONFIG_MTD_BYTE_WRITE
Review comment:
@davids5 That was originally `#if defined(CONFIG_MTD_BYTE_WRITE) &&
defined(ANOTHER_CFG)` that other config was just a copy/paste typo when
porting, that doesn't apply to this file.
I find "#ifdef" a little explicit compared to `#defined(ONLY_ONE_CFG)` but
the two are equivalent in this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
