tmedicci commented on code in PR #20224:
URL: https://github.com/apache/nuttx/pull/20224#discussion_r4066061413
##########
arch/risc-v/src/common/espressif/esp_irq.c:
##########
Review Comment:
Please check its return code to ensure we are not overwritting a handle.
```suggestion
ret = esp_set_handle(this_cpu(), irq, ret_handle);
if (ret < 0)
{
irqerr("Failed to store handle for IRQ %d\n", irq);
if (esp_intr_free(ret_handle) == ESP_OK)
{
kmm_free(isr_adapter_args);
}
else
{
irqerr("Failed to free untracked interrupt for IRQ %d\n", irq);
}
return ret;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
