jerpelea opened a new pull request, #20269:
URL: https://github.com/apache/nuttx/pull/20269

   ## Summary
   
   Re-enables nxinit as the top-level init on esp32s3-xiao (restoring the
   entrypoint switch from 7cc6707a76b10cc951f209c09b7f2b6cd228e535,
   reverted in 76b90e02cbe4967193b620abcb1efb9f6b3f8f5b after a
   real-hardware regression report — board hangs, no USB console, on
   Seeed XIAO ESP32-S3), this time actually fixing the root cause instead
   of just reverting it.
   
   Root cause: the shared boards/xtensa/esp32s3 init.rc starts the
   interactive console as a plain "sh", which, unlike nsh_main's
   nsh_consolemain(), never registers/connects the CDC-ACM gadget this
   board uses as its console (CONFIG_CDCACM_CONSOLE=y, no
   CONFIG_DEV_CONSOLE). Restoring the entrypoint switch on its own is
   not sufficient — it would just reintroduce the same regression, so
   that revert is folded into this change rather than kept as a separate,
   individually-broken commit.
   
   Fix, using the "console" service option added to nxinit by the
   companion https://github.com/apache/nuttx-apps/pull/3776:
   
       init.rc: bring up the console gadget once, unconditionally, before
       any service starts, via exec -- sercon (apps/system/cdcacm
       already implements exactly this and depends on neither nxinit nor
       nsh); flag the "console" service with the new console option so
       its stdio is connected to the (now registered) gadget device.
       esp32s3-xiao's usbnsh/combo defconfigs: add
       CONFIG_SYSTEM_CDCACM=y so sercon is actually built in. Generated
       with make savedefconfig against both defconfigs (byte-identical to
       the committed diff, no manual edits).
   
   Depends on https://github.com/apache/nuttx-apps/pull/3776 ("console" service 
option) —
   without it, init.rc's console line would fail to parse.
   
   ## Impact
   
   RELEASE
   
   ## Testing
   
   CI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to