daniel-p-carvalho commented on code in PR #3800:
URL: https://github.com/apache/nuttx-apps/pull/3800#discussion_r4111611787
##########
netutils/ptpd/ptpd.c:
##########
@@ -1019,7 +1046,7 @@ static int ptp_get_tx_timestamp(FAR struct ptp_state_s
*state,
else
{
ptpwarn("PTP TX HWTS: poll ret=%d revents=0x%04x errno=%d\n",
- ret, pfd.revents, errno);
+ ret, (unsigned int)pfd.revents, errno);
Review Comment:
Done, dropped the cast and switched the format to PRIx32, since pollevent_t
is uint32_t:
ptpwarn("PTP TX HWTS: poll ret=%d revents=0x%04" PRIx32
" errno=%d\n", ret, pfd.revents, errno);
##########
netutils/ptpd/ptpd.c:
##########
@@ -778,13 +790,28 @@ static int ptp_initialize_state(FAR struct ptp_state_s
*state)
ret = ioctl(state->event_socket, SIOCETHTOOL, (unsigned long)&req);
if (ret < 0)
{
- ptpwarn("ETHTOOL_GET_TS_INFO failed for %s: %d\n",
- state->config->interface, errno);
+ ptperr("ETHTOOL_GET_TS_INFO failed for %s: %d\n",
Review Comment:
Done, the first patch now logs the ETHTOOL_GET_TS_INFO failure with ptperr
and returns ERROR, so the second patch no longer touches it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
