casaroli commented on code in PR #20368: URL: https://github.com/apache/nuttx/pull/20368#discussion_r4130339123
########## libs/libc/elf/elf_bind.c: ########## @@ -674,6 +748,15 @@ static int libelf_relocatedyn(FAR struct module_s *modp, int i; int idx_rel; int idx_sym; +#if CONFIG_LIBC_ELF_MAXDEPEND > 0 + int j; +#endif +#ifdef LIBELF_NEEDED Review Comment: `libs[]` is only used where `DT_NEEDED` is followed, which excludes `CONFIG_ARCH_ADDRENV`, so under one `CONFIG_LIBC_ELF_MAXDEPEND` guard it would be unused there and break `-Werror`. `libs[]` and `nlibs` now share one guard, next to `j`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
