royzah commented on code in PR #20412:
URL: https://github.com/apache/nuttx/pull/20412#discussion_r4162959247
##########
include/nuttx/addrenv.h:
##########
@@ -540,6 +540,7 @@ void addrenv_drop(FAR struct addrenv_s *addrenv, bool
deferred);
bool access_ok(FAR const void *ptr, size_t len);
bool uaccess_nested(FAR const void *parent, FAR const void *ptr);
void uaccess_check(FAR const void *ptr, size_t len);
+void uaccess_fault(FAR const void *ptr) noreturn_function;
Review Comment:
done, uaccess_fault is in the first patch now
##########
tools/mksyscall.c:
##########
@@ -35,9 +35,29 @@
* Private Data
****************************************************************************/
+struct uvalue_s
+{
+ const char *name;
+ int parm;
+};
+
static bool g_inline;
static FILE *g_stubstream;
+static const char * const g_uwrapped[] =
Review Comment:
yep split it. this PR is only the helpers + arch side now. the stub/wrapper
part goes in its own PR after this lands, we can talk there if checks should
live in the stubs or in the functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
