royzah commented on code in PR #20439: URL: https://github.com/apache/nuttx/pull/20439#discussion_r4167638945
########## sched/signal/sig_default.c: ########## @@ -228,8 +228,6 @@ static void nxsig_abnormal_termination(int signo) group_kill_children(rtcb); #endif - tls_cleanup_popall(tls_get_info()); Review Comment: agree for cancel: async pthread_cancel still runs them from the kernel today. plan is the kernel marks the cancel pending and signals the target, its libc handler calls pthread_exit, so handlers run in the target's own user mode. but for death by signal, POSIX runs none (same as _exit), linux too. so this PR just drops the signal case, and the cancel one comes as a follow-up after #20425 since it touches the same function. ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
