xiaoxiang781216 commented on code in PR #20553: URL: https://github.com/apache/nuttx/pull/20553#discussion_r4229931395
########## tools/test_fmaf.c: ########## @@ -0,0 +1,275 @@ +/**************************************************************************** + * tools/test_fmaf.c Review Comment: move to nuttx-apps.git testing/ folder ########## libs/libm/libm/Make.defs: ########## @@ -30,6 +30,14 @@ CSRCS += lib_acoshf.c lib_atanhf.c lib_erff.c lib_copysignf.c CSRCS += lib_scalbnf.c lib_scalbn.c lib_scalbnl.c lib_sincos.c CSRCS += lib_sincosf.c lib_sincosl.c +ifeq ($(CONFIG_LIBM_ARCH_FMAF),y) +CSRCS += lib_fmaf_riscv.c +DEPPATH += --dep-path libm/risc-v Review Comment: move to risc-v/Make.defs ########## libs/libm/libm/Kconfig: ########## @@ -10,6 +10,11 @@ # Default settings for C library functions that may be replaced with # architecture-specific versions. +config LIBM_ARCH_FMAF + bool + default y Review Comment: `default n` and select in risc-v/Kconfig, please follow how arm enable the arch specific implementation ########## libs/libm/libm/Make.defs: ########## @@ -30,6 +30,14 @@ CSRCS += lib_acoshf.c lib_atanhf.c lib_erff.c lib_copysignf.c CSRCS += lib_scalbnf.c lib_scalbn.c lib_scalbnl.c lib_sincos.c CSRCS += lib_sincosf.c lib_sincosl.c +ifeq ($(CONFIG_LIBM_ARCH_FMAF),y) +CSRCS += lib_fmaf_riscv.c +DEPPATH += --dep-path libm/risc-v +VPATH += :libm/risc-v +else +CSRCS += lib_fmaf.c Review Comment: move after line 119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
