casaroli opened a new pull request, #3831: URL: https://github.com/apache/nuttx-apps/pull/3831
## Summary `netutils/netcat/netcat_main.c` uses `errno` and `true`, and `system/nxinit/parser.c` uses `errno`, `E2BIG`, `EINTR` and `EINVAL`. Neither file includes `errno.h`, and `netcat_main.c` does not include `stdbool.h`. They compile only because `stdio.h` includes them indirectly. This PR adds the includes. The first commit adds a blank line in `netcat_main.c` to fix its old nxstyle error. It does not change code. ## Impact None. The two files include what they use. ## Testing Builds with `-Wno-cpp -Werror` and a `stdio.h` that does not include `nuttx/fs/fs.h` and `nuttx/lib/lib.h` (see apache/nuttx#20565): | Configuration | File | Before | After | |---|---|---|---| | `lm3s6965-ek:qemu-flat` | `netcat_main.c` | error | OK | | `rv-virt:nsh64` | `nxinit/parser.c` | 6 errors | OK | Both configurations also build on unmodified nuttx master. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
