xiaoxiang781216 commented on code in PR #20596: URL: https://github.com/apache/nuttx/pull/20596#discussion_r4244478157
########## binfmt/binfmt_copyargv.c: ########## @@ -41,11 +41,11 @@ * Pre-processor Definitions ****************************************************************************/ -/* This is an artificial limit to detect error conditions where an argv[] - * list is not properly terminated. +/* This limit also detects error conditions where an argv[] list is not + * properly terminated. */ -#define MAX_EXEC_ARGS 256 +#define MAX_EXEC_ARGS CONFIG_TASK_MAX_ARGS Review Comment: ditto ########## sched/task/task_setup.c: ########## @@ -49,11 +49,11 @@ * Pre-processor Definitions ****************************************************************************/ -/* This is an artificial limit to detect error conditions where an argv[] - * list is not properly terminated. +/* This limit also detects error conditions where an argv[] list is not + * properly terminated. */ -#define MAX_STACK_ARGS 256 +#define MAX_STACK_ARGS CONFIG_TASK_MAX_ARGS Review Comment: let's use CONFIG_TASK_MAX_ARGS in the code directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
