casaroli commented on code in PR #20565: URL: https://github.com/apache/nuttx/pull/20565#discussion_r4248088836
########## include/stdio.h: ########## @@ -33,8 +33,17 @@ #include <stdarg.h> #include <time.h> -#include <nuttx/fs/fs.h> -#include <nuttx/lib/lib.h> +#include <nuttx/mutex.h> +#include <nuttx/queue.h> + +/* Kernel code, and every program of a flat or protected build, still sees + * the file system types through stdio.h. The programs of a kernel build + * cannot use them, and do not see them. + */ + +#if !defined(CONFIG_BUILD_KERNEL) || defined(__KERNEL__) +# include <nuttx/fs/fs.h> Review Comment: OK, I will remove it in a follow-up PR. ########## include/nuttx/tls.h: ########## @@ -50,6 +53,13 @@ * Pre-processor Definitions ****************************************************************************/ +/* Stream flags for the fs_flags field of in struct file_struct */ Review Comment: Done: the flags are in stdio.h now, next to struct file_struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
