casaroli commented on code in PR #3839:
URL: https://github.com/apache/nuttx-apps/pull/3839#discussion_r4248090304
##########
system/zlib/Makefile:
##########
@@ -33,6 +33,10 @@ CFLAGS += -Dunix -Wno-shadow -Wno-strict-prototypes
-Wno-undef
CFLAGS += ${INCDIR_PREFIX}zlib
zlib/test/infcover.c_CFLAGS += -Wno-format
+# gzlib.c, gzread.c and gzwrite.c use lseek(), read() and write()
+
+CFLAGS += -include unistd.h
Review Comment:
Done: after the download, the build makes zconf.h include unistd.h, the same
change zlib's configure makes on Unix (`#ifdef HAVE_UNISTD_H` becomes `#if 1`),
in Make and CMake.
A define only on the zlib command line would give zlib and its users
different z_off_t types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
