v01d commented on a change in pull request #1786:
URL: https://github.com/apache/incubator-nuttx/pull/1786#discussion_r488688156
##########
File path: tools/Makefile.unix
##########
@@ -455,28 +462,28 @@ pass2dep: context tools/mkdeps$(HOSTEXEEXT)
tools/cnvwindeps$(HOSTEXEEXT)
# file in the NuttX tools GIT repository for additional information.
config: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
Kconfig
oldconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --oldconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
--oldconfig Kconfig
olddefconfig: apps_preconfig
- $(Q) APPSDIR=${CONFIG_APPS_DIR} kconfig-conf --olddefconfig Kconfig
+ $(Q) APPSDIR=${CONFIG_APPS_DIR} EXTERNALDIR=$(EXTERNALDIR) kconfig-conf
--olddefconfig Kconfig
Review comment:
Maybe I could add "export APPDIR" but inside apps repo. I will look if
it makes sense to export it at the top-level of nuttx build (technically it
should not be necessary). EXTERNALDIR is the environment variable only passed
to Kconfig, these lines are the only place where they are passed around so no
need for the export.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
