casaroli opened a new pull request, #3854: URL: https://github.com/apache/nuttx-apps/pull/3854
## Summary The check job runs checkpatch on `github.event.pull_request.base.sha..HEAD`. `HEAD` is the merge commit that GitHub made for the pull request, and that merge commit can be on an older base than `base.sha`. checkpatch diffs the two endpoints, so every change on master since that older base looks like a change of the pull request, and old style errors in those files fail the check. This happened on apache/nuttx#20640: its merge commit was on an old master, and `check` failed with nxstyle errors in three files that the PR does not touch. This PR fetches the base branch and checks from the merge base of the base branch and `HEAD`. It is the same change as apache/nuttx#20696. ## Impact CI only. The check job checks only the commits and files of the pull request. ## Testing Simulated with apps PR #3846 (fork point 7e03b989c, master 12 commits ahead). I made a merge commit of its head on an older master (467e22088), with `base.sha` = master b1a17ba45: - Old range: 11 files (10 of them changed on master, not by the PR) and one commit. - New range: only `.github/workflows/build.yml` and the same commit, which is the PR's own change. With a merge commit on the current base, both ranges are the same. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
