imeghar2408-max commented on code in PR #3840:
URL: https://github.com/apache/nuttx-apps/pull/3840#discussion_r4296916323


##########
include/system/nxplayer.h:
##########
@@ -40,12 +41,17 @@
  * Public Type Declarations
  ****************************************************************************/
 
+struct nxplayer_s;
+
 struct nxplayer_dec_ops_s
 {
   int format;
-  CODE int (*pre_parse)(int fd, FAR uint32_t *samplerate,
-                        FAR uint8_t *chans, FAR uint8_t *bps);
-  CODE int (*fill_data)(int fd, FAR struct ap_buffer_s *apb);
+  CODE int (*pre_parse)(FAR struct nxplayer_s *pplayer, int fd,

Review Comment:
   I removed the adapters and modified the MP3/SBC callbacks directly to use 
the shared decoder interface.
   I've also split the changes into two commits.. waiting for your review:)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to