casaroli opened a new pull request, #3857: URL: https://github.com/apache/nuttx-apps/pull/3857
## Summary #3848 added the Kconfig option `MBEDTLS_DES_C`. The Espressif HAL reads `CONFIG_MBEDTLS_DES_C` too: it is an ESP-IDF option with the same name, and the HAL then defines `MBEDTLS_DES_C` for its own Mbed TLS ([esp_config.h:2088](https://github.com/espressif/esp-hal-3rdparty/blob/cf95a27f2aa263d77c7a8d7f56007abfc899fc47/components/mbedtls/port/include/mbedtls/esp_config.h#L2088)). That Mbed TLS (TF-PSA-crypto) does not support DES, so `esp32s3-devkit:mbedtls` stops with: ``` tf_psa_crypto_config_check_user.h:153:4: error: #error "MBEDTLS_DES_C is not a valid configuration option." ``` This PR removes the option. `mbedtls_config.h` defines `MBEDTLS_DES_C` unless `MBEDTLS_MINIMAL` is set, as the option's default did. Only the possibility to disable DES alone, without `MBEDTLS_MINIMAL`, goes away. The error was already in the CI of #3848, but `Linux (xtensa-03)` shows "cancelled" there: `arm-13` failed on the nxboot break and fail-fast stopped the job after it had hit this error. CI logs: - apps #3848, `Linux (xtensa-03)` (cancelled, error at 22:31): https://github.com/apache/nuttx-apps/actions/runs/38791329589/job/116656848371 - apache/nuttx#20705, `Linux (xtensa-03)`: https://github.com/apache/nuttx/actions/runs/38907729803/job/116998721880 - apache/nuttx#20703, `Linux (xtensa-03)`: https://github.com/apache/nuttx/actions/runs/38905530048/job/116993583358 ## Impact Every nuttx PR whose CI builds `xtensa-03` fails on `esp32s3-devkit:mbedtls` since #3848 merged; this PR fixes that. No defconfig in nuttx or apps sets `CONFIG_MBEDTLS_DES_C`. ## Testing Local build of `esp32s3-devkit:mbedtls` (nuttx master c006807501d, xtensa-esp-elf 14.2.0, the same as CI): - apps master 06a5ce3ed: fails with the error above (`CONFIG_MBEDTLS_DES_C=y`). - this PR: builds; the apps Mbed TLS still compiles `des.c` and the image has the `mbedtls_des_*` functions. Preprocessing `mbedtls_config.h`: `MBEDTLS_DES_C` is defined without `CONFIG_MBEDTLS_MINIMAL`, and not defined with it. `tools/checkpatch.sh -c -u -m -g` passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
