raiden00pl commented on code in PR #20686: URL: https://github.com/apache/nuttx/pull/20686#discussion_r4291657658
########## boards/sim/sim/sim/configs/bt/defconfig: ########## @@ -0,0 +1,158 @@ +############################################################################ +# boards/sim/sim/sim/configs/bt/defconfig +# +# Copyright (c) ByteDance Ltd. and/or its affiliates. Review Comment: > The new stack being proposed takes the opposite approach: it starts in the kernel where it belongs architecturally (just like TCP/IP, CAN, and other in-kernel network stacks), and then we add proper userspace access through the socket layer — the same pattern every other NuttX network subsystem follows. That's not treating Bluetooth "specially" — it's treating it consistently with the rest of the OS. No it's not. TCP/IP, CAN and other in-kernel networks stacks occupy different OSI layers. This PR puts all OSI layers to kernel which is obviously wrong. Everything above L4-L5 that resides in the kernel is controversial. What you are proposing is equivalent to embedding HTTP, REST or CANopen into the kernel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
